-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8956 - Improve swaplist drop area #8978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The drop area is now bigger.
Screen.Recording.2024-08-22.at.2.36.59.PM.mov
But, there is this animation going back to its origin when trying to drop the item just below the drop area. Look at the 0:05 at the video below
Screen.Recording.2024-08-22.at.2.38.07.PM.mov
Also, in RTL its working, but the rounded edge of the boxes are facing the wrong sides when flipped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good from me. Maybe look at @n-ace-ancog 's point? I didnt notice the animation in the video but we could fix the rounding ect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same observation with @n-ace-ancog regarding the animation.
Screen.Recording.2024-08-27.at.12.19.21.PM.mov
@n-ace-ancog, the animation rollback occurs because the target area doesn’t fully cover the card content area. I’ve made an adjustment so that if you drag outside the area of the existing swap list item, the indicator will cover the entire card content area. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are good here then? |
Explain the details for making this change. What existing problem does the pull request solve?
This PR improves the size of the SwapList's drop area when there are no existing items and also fixes some UI inconsistencies.
Additional:
Related github/jira issue (required):
Closes #8956
Steps necessary to review your pull request (required):
Included in this Pull Request:
- [ ] A test for the bug or feature.