Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8963 - Fixed special characters being encoded in editor #8979

Merged
merged 3 commits into from
Aug 27, 2024
Merged

8963 - Fixed special characters being encoded in editor #8979

merged 3 commits into from
Aug 27, 2024

Conversation

yohannahbautista
Copy link
Contributor

@yohannahbautista yohannahbautista commented Aug 22, 2024 •
edited by tmcconechy
Loading

Explain the details for making this change. What existing problem does the pull request solve?

Removed escape HTML so that special characters won't be encoded

Related github/jira issue (required):

Closes #8963

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

@yohannahbautista yohannahbautista requested a review from a team as a code owner August 22, 2024 07:16
n-ace-ancog
n-ace-ancog previously approved these changes Aug 22, 2024
View reviewed changes
Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on my end.

Screen.Recording.2024-08-22.at.4.31.57.PM.mov

@ericangeles
Copy link
Contributor

Could you add test here, @yohannahbautista ?

tmcconechy
tmcconechy previously approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (agree with the tests idea)

glenlieorillo
glenlieorillo previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-08-27.at.12.59.31.PM.mov

jbrcna
jbrcna approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@tmcconechy tmcconechy merged commit 5efe390 into main Aug 27, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 8963-spec-char branch August 27, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericangeles ericangeles ericangeles approved these changes

@jbrcna jbrcna jbrcna approved these changes

@tmcconechy tmcconechy tmcconechy left review comments

@glenlieorillo glenlieorillo glenlieorillo left review comments

@n-ace-ancog n-ace-ancog n-ace-ancog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datagrid: Encoded special characters on inline editors
6 participants
@yohannahbautista @ericangeles @tmcconechy @jbrcna @glenlieorillo @n-ace-ancog