Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8980 - Datagrid Contextual Toolbar Hover #8989

Merged
merged 4 commits into from
Aug 29, 2024
Merged

8980 - Datagrid Contextual Toolbar Hover #8989

merged 4 commits into from
Aug 29, 2024

Conversation

tjamesallen15
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?

This pull request will fix datagrid hover color for contextual toolbar when a row is selected.

Related github/jira issue (required):
Closes #8980

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@tjamesallen15 tjamesallen15 marked this pull request as ready for review August 27, 2024 03:58
@tjamesallen15 tjamesallen15 requested a review from a team as a code owner August 27, 2024 03:58
n-ace-ancog
n-ace-ancog previously approved these changes Aug 27, 2024
View reviewed changes
Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on my end.

image

image

image

@ericangeles
Copy link
Contributor

Looks good! Can we also add a visual test, @tjamesallen15?

glenlieorillo
glenlieorillo previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

tmcconechy
tmcconechy previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Better try all button types (icon/tertiary/text only) on the example? From the other comment mentioned

@tjamesallen15
Copy link
Contributor Author

Will add test

jbrcna
jbrcna previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image image

@tmcconechy tmcconechy merged commit 31c330d into main Aug 29, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 8980-datagrid-contextual-toolbar branch August 29, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmcconechy tmcconechy tmcconechy left review comments

@jbrcna jbrcna jbrcna left review comments

@glenlieorillo glenlieorillo glenlieorillo left review comments

@n-ace-ancog n-ace-ancog n-ace-ancog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datagrid: Contextual Toolbar button colors
6 participants
@tjamesallen15 @ericangeles @tmcconechy @jbrcna @glenlieorillo @n-ace-ancog