Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NG1759 - Fixed selected filters being cleared when changing row size #8997

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

yohannahbautista
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?

Fixed selected filters being cleared when changing row size

Related github/jira issue (required):

Closes infor-design/enterprise-ng#1759

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

@yohannahbautista yohannahbautista requested a review from a team as a code owner August 30, 2024 02:48
glenlieorillo
glenlieorillo previously approved these changes Aug 30, 2024
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-08-30.at.3.55.56.PM.mov

ericangeles
ericangeles previously approved these changes Aug 30, 2024
Copy link
Contributor

@ericangeles ericangeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! 🍌

Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to not work in Activity(multi) filter
Large GIF (1310x714)

@ericangeles
Copy link
Contributor

@jbrcna, can you retest it again?

@jbrcna
Copy link
Contributor

jbrcna commented Sep 3, 2024

@jbrcna, can you retest it again?

yes absolutely.

Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected.
image
image
image

@tmcconechy tmcconechy merged commit ad24c0c into main Sep 3, 2024
4 checks passed
@tmcconechy tmcconechy deleted the ng-1759-datagrid-filter branch September 3, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGrid: Filter values cleared when changing row height
5 participants