Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8487 - Adjusted width calculation in searchfield #9011

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Conversation

yohannahbautista
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?

When screen is below slim breakpoint (400), the width calculated becomes too big once a category button is included. Put a check if the screen is below 400, add more in subtractWidth (variable used to shorten the searchfield if it includes components like category button).

Related github/jira issue (required):

Closes #8487

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

… and the screen is less than the slim breakpoint
@yohannahbautista yohannahbautista requested a review from a team as a code owner September 9, 2024 07:17
@tmcconechy tmcconechy merged commit 15a6bb5 into main Sep 9, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 8487-searchfield branch September 9, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchField: Category update is not working properly.
2 participants