Remove chain runtime #3341
Closed
Remove chain runtime #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
commented
May 17, 2023
|
|
||
| /// A cached copy of the account information | ||
| account: Option<Account>, | ||
| account: AsyncRwLock<Option<Account>>, |
There was a problem hiding this comment.
Here's the lock for the account
| get_or_fetch_account(&self.grpc_addr, &key_account, &mut self.account).await?; | ||
| // Take a write lock on the current account, | ||
| // excluding anybody from sending txs until we are done. | ||
| let mut opt_account = self.account.write().await; |
There was a problem hiding this comment.
We take the lock here for the remaining duration of the function, ie. until the tx has been submitted.
|
|
||
| // Take a write lock on the current account, | ||
| // excluding anybody from sending txs until we are done. | ||
| let mut opt_account = self.account.write().await; |
There was a problem hiding this comment.
We take the lock here for the remaining of the function, ie. until the counterparty payee has been registered.
… the chain (#3350) * Limit the maximum number of requests which can issued concurrently to the chain Controlled via the `max_concurrency` setting in the chain configuration. * Swap out `rsevents-extra` for `std-semaphore`
|
Is this PR just waiting on reviews at this point, or does it need more work? |
|
Reviews and some testing, ideally in prod ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3344
Description
By removing the chain runtime, we can issue queries concurrently rather than serially, which has the potential to speed up relaying in two cases:
a) when relaying on multiple channels between two or more chains
b) when relaying between a chain A and two or more chains B, C, ... with A<->B, A<->C, ...
Note that it won't let us send multiple txs concurrently because of the monotonic constraint on the account sequence number. To speed up this aspect of the relayer, we would need multiple wallets.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.