Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement basic IBC channel handshake in relayer-next #3463

Merged
merged 9 commits into from
Jul 10, 2023
Merged

Implement basic IBC channel handshake in relayer-next #3463

merged 9 commits into from
Jul 10, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Jul 5, 2023 •
edited
Loading

Part of: #2925

Description

This PR implements the basic IBC channel handshake components in relayer-next.

The current implementation supports only an end-to-end IBC channel creation, and does not resume connection handshake based on IBC events.
The checks are not performed, e.g. verifying that the connection exists on destination https://github.com/informalsystems/hermes/blob/v1.5.1/crates/relayer/src/channel.rs#L1116.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 added the O: relayer-next Objective: work toward relayer v2 label Jul 7, 2023
@ljoss17 ljoss17 marked this pull request as ready for review July 7, 2023 07:22
soareschen
soareschen approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@soareschen soareschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, awesome work!

@soareschen soareschen merged commit 6251577 into soares/relayer-next Jul 10, 2023
45 of 47 checks passed
@soareschen soareschen deleted the luca_joss/channel-handshake-next branch July 10, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soareschen soareschen soareschen approved these changes

Assignees
No one assigned
Labels
O: relayer-next Objective: work toward relayer v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljoss17 @soareschen