Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UpdateClient chain components and remove depdency to ForeignClient #3480

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

soareschen
Copy link
Contributor

Closes: #2780

Description

This PR implements the minimal UpdateClient components for the chain context. A new abstract UpdateClient component is implemented for the relay context make use of the chain context components. With that, we remove the methods for building UpdateClient messages from the OfaRelay trait. The end result is that the Cosmos relay context no longer depends on the ForeignClient to perform any relaying operation.

Note that this PR only implements the minimal logic for UpdateClient. It does not perform additional checks such as misbehavior detection, or validating the client state and consensus state on the counterparty chain. These logic will be implemented in follow up PRs.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen merged commit c7763f5 into soares/relayer-next Jul 14, 2023
42 of 49 checks passed
@soareschen soareschen deleted the soares/update-client-next branch July 14, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant