Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IBC chain constructs #3483

Merged
merged 17 commits into from
Jul 17, 2023
Merged

Refactor IBC chain constructs #3483

merged 17 commits into from
Jul 17, 2023

Conversation

soareschen
Copy link
Contributor

Description

This PR includes various refactoring of the IBC chain traits and constructs. This is in preparation for a more generic implementation of the OfaIbcChain for CosmosChain, so that it can support other chain contexts such as solomachine being the Counterparty chain.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen added the O: relayer-next Objective: work toward relayer v2 label Jul 17, 2023
@soareschen soareschen merged commit 24052d5 into soares/relayer-next Jul 17, 2023
48 of 49 checks passed
@soareschen soareschen deleted the soares/refactor-ofa-chain branch July 17, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
O: relayer-next Objective: work toward relayer v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@soareschen