Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on safe-regex for regex #3556

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Remove dependency on safe-regex for regex #3556

merged 3 commits into from
Aug 23, 2023

Conversation

romac
Copy link
Member

@romac romac commented Aug 22, 2023 •
edited
Loading

Closes: #3549

Description

This fixes the docs.rs build failure reported in #3549.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac changed the title Remove dependency on safe-regex for regex-lite Remove dependency on safe-regex for regex Aug 22, 2023
@romac romac marked this pull request as ready for review August 22, 2023 14:17
@romac romac merged commit 6621d70 into master Aug 23, 2023
40 checks passed
@romac romac deleted the romac/3549-fix-doc-build branch August 23, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanchen1991 seanchen1991 seanchen1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing ibc-relayer-types docs.rs documentation
2 participants
@romac @seanchen1991