Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for changing tracing directives at runtime #3565

Merged
merged 14 commits into from
Sep 12, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Aug 25, 2023

Closes: #3564

Description

This PR adds a handler which allows users to update tracing log directives without restarting Hermes.

Three CLIs are also added to facilitate this:

  • hermes logs set-log-level which update the log level
  • hermes logs set-raw-filter which send an arbitrary string used as a new tracing directive
  • hermes logs reset! which resets the log level using the one defined in the config.toml

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested a review from romac August 25, 2023 14:29
@romac romac changed the title Update tracing directives on runtime Add support for changing tracing directives at runtime Sep 6, 2023
@romac romac marked this pull request as ready for review September 12, 2023 14:36
@romac romac merged commit c077ee7 into master Sep 12, 2023
23 checks passed
@romac romac deleted the luca_joss/configure-tracing-logs branch September 12, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tracing directives on runtime
2 participants