fix: fixed dynamic_gas_queried_success_fees metric name

[freak12techno]

Closes: #4145

Description

Fixes a typo in metric name. This is what now curl localhost:3001/metrics responds:

# TYPE dynamic_gas_paid_fees histogram
dynamic_gas_paid_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.0025"} 0
dynamic_gas_paid_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.005"} 0
dynamic_gas_paid_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.01"} 2
dynamic_gas_paid_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.05"} 2
dynamic_gas_paid_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.1"} 2
dynamic_gas_paid_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.5"} 2
dynamic_gas_paid_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="1"} 2
dynamic_gas_paid_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="5"} 2
dynamic_gas_paid_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="+Inf"} 2
dynamic_gas_paid_fees_sum{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version=""} 0.01166
dynamic_gas_paid_fees_count{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version=""} 2
# HELP dynamic_gas_queried_fees The EIP-1559 base fee queried
# TYPE dynamic_gas_queried_fees histogram
dynamic_gas_queried_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.0025"} 0
dynamic_gas_queried_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.005"} 0
dynamic_gas_queried_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.01"} 2
dynamic_gas_queried_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.05"} 2
dynamic_gas_queried_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.1"} 2
dynamic_gas_queried_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.5"} 2
dynamic_gas_queried_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="1"} 2
dynamic_gas_queried_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="5"} 2
dynamic_gas_queried_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="+Inf"} 2
dynamic_gas_queried_fees_sum{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version=""} 0.01166
dynamic_gas_queried_fees_count{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version=""} 2
# HELP dynamic_gas_queried_success_fees The EIP-1559 base fee successfully queried
# TYPE dynamic_gas_queried_success_fees histogram
dynamic_gas_queried_success_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.0025"} 0
dynamic_gas_queried_success_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.005"} 0
dynamic_gas_queried_success_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.01"} 2
dynamic_gas_queried_success_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.05"} 2
dynamic_gas_queried_success_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.1"} 2
dynamic_gas_queried_success_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="0.5"} 2
dynamic_gas_queried_success_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="1"} 2
dynamic_gas_queried_success_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="5"} 2
dynamic_gas_queried_success_fees_bucket{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version="",le="+Inf"} 2
dynamic_gas_queried_success_fees_sum{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version=""} 0.01166
dynamic_gas_queried_success_fees_count{identifier="neutron-1",service_name="unknown_service",otel_scope_name="hermes",otel_scope_version=""} 2

Prometheus seems to not complain about it anymore, so guess it's good.

---

PR author checklist:

• Added changelog entry, using unclog.
• Added tests: integration (for Hermes) or unit/mock tests (for modules).
• Linked to GitHub issue.
• Updated code comments and documentation (e.g., docs/).
• Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

• Reviewed Files changed in the GitHub PR explorer.
• Manually tested (in case integration/unit/mock tests are absent).

[romac]

Looks good, thanks for catching this! 🙏

[romac]

@ljoss17 By the way, can you please remind me why we have these two metrics instead of just one?

[ljoss17]

@ljoss17 By the way, can you please remind me why we have these two metrics instead of just one?

There are actually three metrics, and the issue here is that two of them had the same label.
The reason we have multiple is to identify if the query for dynamic gas fees fails. In order to still try to relay, we fallback to the configured gas price to still try and relay the packet if the query fails.
So we have:

• dynamic_gas_queried_success_fees will be the gas price queried from the endpoint
• dynamic_gas_queried_fees will be the retrieved gas price, this can be the queried value or the configured gas price if the query failed
• dynamic_gas_paid_fees will be the gas price used to relay, this can be the queried value or the configured gas price if the query failed, after reducing the price if it exceeds the configured max value