Deserialize ics20 v2 packet data with Protobuf #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
approved these changes
Aug 27, 2024
ljoss17
merged commit d4816ff
into
luca_joss/add-compatibility-to-ics20-v2
30 checks passed
ljoss17
deleted the
luca_joss/deserialize-ics20-v2-packet-data-with-protobuf
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4098
Description
The encoding if ICS20 v2 PacketData was switched from JSON to Protobuf, cosmos/ibc#1097. This PR updates how the packet data is deserialized when checking the length of the receiver and memo field.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.