cleanup logging around UpdateMatchingStatsSqlJob.java

ingef · Nov 11, 2024 · 25dbe80 · 25dbe80
1 parent bc7539b
commit 25dbe80
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 19 deletions.
diff --git a/backend/src/main/java/com/bakdata/conquery/apiv1/LabelMap.java b/backend/src/main/java/com/bakdata/conquery/apiv1/LabelMap.java
@@ -10,20 +10,19 @@
 import com.bakdata.conquery.models.query.FilterSearch;
 import com.bakdata.conquery.util.search.TrieSearch;
 import com.google.common.collect.BiMap;
-import lombok.EqualsAndHashCode;
-import lombok.Getter;
-import lombok.RequiredArgsConstructor;
+import lombok.Data;
+import lombok.ToString;
 import lombok.experimental.Delegate;
 import lombok.extern.slf4j.Slf4j;
-import org.apache.commons.lang3.time.StopWatch;
 
-@Getter
-@RequiredArgsConstructor
 @Slf4j
-@EqualsAndHashCode
+@Data
+@ToString(onlyExplicitlyIncluded = true)
 public class LabelMap implements Searchable {
 
+	@ToString.Include
 	private final FilterId id;
+
 	@Delegate
 	private final BiMap<String, String> delegate;
 	private final int minSuffixLength;
@@ -42,20 +41,10 @@ public TrieSearch<FrontendValue> createTrieSearch(IndexConfig config) {
 			log.trace("Labels for {}: `{}`", getId(), collected.stream().map(FrontendValue::toString).collect(Collectors.toList()));
 		}
 
-		StopWatch timer = StopWatch.createStarted();
-		log.trace("START-SELECT ADDING_ITEMS for {}", getId());
-
 		collected.forEach(feValue -> search.addItem(feValue, FilterSearch.extractKeywords(feValue)));
 
-		log.trace("DONE-SELECT ADDING_ITEMS for {} in {}", getId(), timer);
-
-		timer.reset();
-		log.trace("START-SELECT SHRINKING for {}", getId());
-
 		search.shrinkToFit();
 
-		log.trace("DONE-SELECT SHRINKING for {} in {}", getId(), timer);
-
 		return search;
 	}
 

diff --git a/backend/src/main/java/com/bakdata/conquery/mode/local/UpdateMatchingStatsSqlJob.java b/backend/src/main/java/com/bakdata/conquery/mode/local/UpdateMatchingStatsSqlJob.java
@@ -184,12 +184,11 @@ public void calculateMatchingStats(final TreeConcept treeConcept) {
 			executionService.fetchStream(finalQuery)
 							.forEach(record -> mapRecordToConceptElements(treeConcept, record, treeCache));
 
+			log.debug("DONE fetching results for {}", treeConcept.getId());
 		}
 		catch (RuntimeException exception) {
 			log.error("FAILED collecting results for {}", treeConcept.getId(), exception);
 		}
-
-		log.debug("DONE fetching results for {}", treeConcept.getId());
 	}
 
 	/**