Add support for multi column validity dates #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsrnhld
commented
Jul 11, 2023
backend/src/main/java/com/bakdata/conquery/apiv1/query/concept/filter/CQTable.java
Show resolved
Hide resolved
awildturtok
reviewed
Jul 12, 2023
backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/ValidityDate.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/ValidityDate.java
Outdated
Show resolved
Hide resolved
jnsrnhld
force-pushed
the
sql/feature/support_multi_column_validity_dates
branch
from
42b8b0c
to
90dea31
Compare
jnsrnhld
force-pushed
the
sql/feature/support_multi_column_validity_dates
branch
from
0cfe2ab
to
0e8c32b
Compare
Co-authored-by: Torben Meyer <[email protected]>
…ect/PostgreSqlFunctionProvider.java Co-authored-by: awildturtok <[email protected]>
Co-authored-by: Jonas Arnhold <[email protected]>
…t_multi_column_validity_dates
delete-merged-branch
bot
deleted the
sql/feature/support_multi_column_validity_dates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @awildturtok, das hier als Vorbereitung für den nächsten PR mit der Abstraktion von date ranges mit 1 oder 2 columns.
Wenn ich mich richtig erinnere sollte das ein extra Commit/PR sein, deswegen: here we are 😄