Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from jest to mocha #1268

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: migrate from jest to mocha #1268

wants to merge 2 commits into from

Conversation

43081j
Copy link
Collaborator

@43081j 43081j commented Sep 19, 2024

Migrates from jest to mocha, c8 and tinyspy.

@coveralls
Copy link

coveralls commented Sep 19, 2024

Coverage Status

coverage: 71.18% (-28.2%) from 99.34%
when pulling 44b3a6b on chopchop-mocha
into 57a192a on master.

@43081j
Copy link
Collaborator Author

43081j commented Sep 19, 2024

The coverage drop suggests we missed some test files. I'll take a look 👍

Also this depends on #1267 to avoid having to do the lint config twice

@43081j
Copy link
Collaborator Author

43081j commented Sep 21, 2024

the exact same number of tests run but the coverage is way down on the tokenizer, so I'm taking a look into that

super strange since the coverage is clearly setup to find the right files, it just calculates a much lower value

maybe jest was lying 🤔

Base automatically changed from chopchop-eslint to master September 23, 2024 04:50
@43081j 43081j force-pushed the chopchop-mocha branch 2 times, most recently from 44b3a6b to ff6a903 Compare September 29, 2024 04:29
@43081j 43081j force-pushed the chopchop-mocha branch 3 times, most recently from 0b99af0 to dab8038 Compare November 18, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants