Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:support multi executor #81

Merged
merged 5 commits into from
Jun 12, 2024
Merged

feat:support multi executor #81

merged 5 commits into from
Jun 12, 2024

Conversation

djm07073
Copy link
Contributor

@djm07073 djm07073 commented Jun 7, 2024

  • support multi bridge executor

@djm07073 djm07073 requested a review from a team as a code owner June 7, 2024 10:00
@codecov Codecov
Copy link

codecov bot commented Jun 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.26316% with 17 lines in your changes missing coverage. Please review.

Project coverage is 50.96%. Comparing base (89f0784) to head (1cefd61).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   50.78%   50.96%   +0.17%     
==========================================
  Files          57       57              
  Lines        4180     4205      +25     
==========================================
+ Hits         2123     2143      +20     
- Misses       1609     1613       +4     
- Partials      448      449       +1
Files Coverage Δ
x/opchild/keeper/msg_server.go 57.33% <100.00%> (+1.16%) ⬆️
x/opchild/keeper/params.go 62.50% <66.66%> (ø)
x/opchild/types/params.go 67.44% <57.14%> (+0.77%) ⬆️
x/opchild/keeper/executor_change.go 27.58% <42.85%> (+1.27%) ⬆️
x/opchild/client/cli/genesis.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

sh-cha
sh-cha reviewed Jun 10, 2024
View reviewed changes
x/opchild/types/plan.go Outdated Show resolved Hide resolved
sh-cha
sh-cha reviewed Jun 10, 2024
View reviewed changes
x/opchild/types/params.go Outdated Show resolved Hide resolved
sh-cha
sh-cha reviewed Jun 10, 2024
View reviewed changes
x/opchild/keeper/params.go Outdated Show resolved Hide resolved
sh-cha
sh-cha approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@sh-cha sh-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djm07073
Copy link
Contributor Author

LGTM

thank you

@djm07073 djm07073 merged commit 210b2c4 into main Jun 12, 2024
5 checks passed
@djm07073 djm07073 deleted the feat/multi-executor branch June 12, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh-cha sh-cha sh-cha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djm07073 @sh-cha