Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom address prefix #91

Merged
merged 9 commits into from
Jul 9, 2024
Merged

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Jul 8, 2024

This PR is to allow l2 to using custom bech32.

  • Introduce pending deposits
    • When we failed to deposit the funds to the To address, then a pending deposit record will be created and the To address can withdraw the funds.
  • Introduce intermediate sender
    • Now we cannot use l1 address as hook executor, so we create intermediate address and send the fund to that intermediate address and execute the hook.

@beer-1 beer-1 requested a review from a team as a code owner July 8, 2024 09:32
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 53.79310% with 67 lines in your changes missing coverage. Please review.

Project coverage is 51.07%. Comparing base (e53de6f) to head (ce19fe2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   51.09%   51.07%   -0.03%     
==========================================
  Files          57       58       +1     
  Lines        4325     4380      +55     
==========================================
+ Hits         2210     2237      +27     
- Misses       1650     1674      +24     
- Partials      465      469       +4     
Files Coverage Δ
x/opchild/client/cli/tx.go 59.32% <100.00%> (+1.01%) ⬆️
x/opchild/keeper/keeper.go 81.72% <100.00%> (+0.19%) ⬆️
x/opchild/types/hook.go 100.00% <100.00%> (ø)
x/ophost/keeper/msg_server.go 61.17% <100.00%> (+0.32%) ⬆️
x/ophost/client/cli/tx.go 60.37% <75.00%> (-1.17%) ⬇️
x/opchild/types/genesis.go 0.00% <0.00%> (ø)
x/ophost/types/tx.go 51.73% <20.00%> (+0.21%) ⬆️
x/opchild/types/tx.go 58.82% <12.50%> (+0.22%) ⬆️
x/opchild/keeper/genesis.go 41.34% <55.00%> (+3.25%) ⬆️
x/opchild/keeper/msg_server.go 55.52% <51.16%> (-1.32%) ⬇️

Copy link
Contributor

@sh-cha sh-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add pending deposits to genesis and add addr info to pendingdeposits proto
others for LGTM

@beer-1 beer-1 force-pushed the feat/allow-arbitrary-addr-format branch from c6e5b17 to 692cc05 Compare July 9, 2024 03:50
@sh-cha sh-cha merged commit b555a4d into main Jul 9, 2024
5 checks passed
@sh-cha sh-cha deleted the feat/allow-arbitrary-addr-format branch July 9, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants