fix condition

initia-labs · Oct 4, 2024 · 27d830c · 27d830c
1 parent efdecad
commit 27d830c
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/x/move/keeper/handler.go b/x/move/keeper/handler.go
@@ -438,17 +438,17 @@ func (k Keeper) dispatchMessage(parentCtx sdk.Context, message vmtypes.CosmosMes
 			sdk.NewAttribute(types.AttributeKeySuccess, fmt.Sprintf("%v", success)),
 		)
 
-		// return error if failed and not allowed to fail
-		if !success && !allowFailure {
-			// emit failed reason event
+		if !success {
+			// return error if failed and not allowed to fail
+			if !allowFailure {
+				return
+			}
+
+			// emit failed reason event if failed and allowed to fail
 			event.AppendAttributes(sdk.NewAttribute(types.AttributeKeyReason, err.Error()))
 			parentCtx.EventManager().EmitEvent(event)
-
-			return
-		}
-
-		// commit if success
-		if success {
+		} else {
+			// commit if success
 			commit()
 		}