Skip to content

Commit

Permalink
prev commit can't get rid of unncessary comma
Browse files Browse the repository at this point in the history
  • Loading branch information
Vritra4 committed Oct 30, 2023
1 parent 5956dea commit a2f5022
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions x/gov/keeper/proposal.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ func (keeper Keeper) SubmitProposal(ctx sdk.Context, messages []sdk.Msg, metadat
return v1.Proposal{}, err
}

// Will hold a comma-separated string of all Msg type URLs.
msgsStr := ""
// Will hold a string slice of all Msg type URLs.
msgs := []string{}

// Loop through all messages and confirm that each has a handler and the gov module account
// as the only signer
for _, msg := range messages {
msgsStr = strings.Join([]string{msgsStr, sdk.MsgTypeURL(msg)}, ",")
msgs = append(msgs, sdk.MsgTypeURL(msg))

// perform a basic validation of the message
if err := msg.ValidateBasic(); err != nil {
Expand Down Expand Up @@ -100,7 +100,7 @@ func (keeper Keeper) SubmitProposal(ctx sdk.Context, messages []sdk.Msg, metadat
sdk.NewEvent(
types.EventTypeSubmitProposal,
sdk.NewAttribute(types.AttributeKeyProposalID, fmt.Sprintf("%d", proposalID)),
sdk.NewAttribute(types.AttributeKeyProposalMessages, msgsStr),
sdk.NewAttribute(types.AttributeKeyProposalMessages, strings.Join(msgs, ",")),
),
)

Expand Down

0 comments on commit a2f5022

Please sign in to comment.