allow to failed with invalid message

x/move/keeper/handler.go

@@ -480,16 +480,16 @@ func (k Keeper) dispatchMessage(parentCtx sdk.Context, message vmtypes.CosmosMes
 
 	var msg proto.Message
 	if stargateMsg, ok := message.(*vmtypes.CosmosMessage__Stargate); ok {
+		// callback only exists in stargate message
+		allowFailure = stargateMsg.Value.AllowFailure
+		callback = stargateMsg.Value.Callback
+		callbackSender = stargateMsg.Value.Sender
+
 		// validate basic & signer check is done in HandleVMStargateMsg
 		msg, err = k.HandleVMStargateMsg(ctx, &stargateMsg.Value)
 		if err != nil {
 			return
 		}
-
-		// callback only exists in stargate message
-		allowFailure = stargateMsg.Value.AllowFailure
-		callback = stargateMsg.Value.Callback
-		callbackSender = stargateMsg.Value.Sender
 	} else {
 		// signer check had been done in moveVM
 		msg, err = types.ConvertToSDKMessage(ctx, NewMoveBankKeeper(&k), NewNftKeeper(&k), message, k.ac, k.vc)

x/move/keeper/handler_test.go

@@ -604,13 +604,13 @@ func TestSubmsgCallback(t *testing.T) {
 	msgData, err := input.EncodingConfig.Codec.MarshalInterfaceJSON(msg)
 	require.NoError(t, err)
 
-	// 1. callback without signer
+	// 0. invalid message should not failed
 	err = input.MoveKeeper.ExecuteEntryFunctionJSON(ctx, senderAddr, vmtypes.TestAddress,
 		"submsg",
 		"stargate",
 		[]vmtypes.TypeTag{},
 		[]string{
-			fmt.Sprintf("\"%s\"", hex.EncodeToString(msgData)),
+			"\"abcd\"",
 			"true",
 			"\"123\"",
 			fmt.Sprintf("\"%s::submsg::callback_without_signer\"", vmtypes.TestAddress),
@@ -625,6 +625,27 @@ func TestSubmsgCallback(t *testing.T) {
 		sdk.NewAttribute("data", "{\"id\":\"123\",\"success\":false}"),
 	), event)
 
+	// 1. callback without signer
+	err = input.MoveKeeper.ExecuteEntryFunctionJSON(ctx, senderAddr, vmtypes.TestAddress,
+		"submsg",
+		"stargate",
+		[]vmtypes.TypeTag{},
+		[]string{
+			fmt.Sprintf("\"%s\"", hex.EncodeToString(msgData)),
+			"true",
+			"\"123\"",
+			fmt.Sprintf("\"%s::submsg::callback_without_signer\"", vmtypes.TestAddress),
+		})
+	require.NoError(t, err)
+
+	events = ctx.EventManager().Events()
+	event = events[len(events)-1]
+
+	require.Equal(t, sdk.NewEvent("move",
+		sdk.NewAttribute("type_tag", "0x2::submsg::ResultEvent"),
+		sdk.NewAttribute("data", "{\"id\":\"123\",\"success\":false}"),
+	), event)
+
 	// events should not be committed
 	for _, e := range events {
 		require.NotEqual(t, e.Type, "move_execute_with_json")