Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] remove max_module_size from param #20

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[fix] remove max_module_size from param #20

merged 1 commit into from
Nov 29, 2023

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Nov 23, 2023

  • remove max_module_size from move parameters
  • make proto-format fixed indents in gov.proto lol

@Vritra4 Vritra4 requested review from beer-1 and a team November 23, 2023 08:27
@Vritra4 Vritra4 self-assigned this Nov 23, 2023
@Vritra4 Vritra4 changed the title [fix]remove max_module_size from param [fix] remove max_module_size from param Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #20 (f1a6653) into main (3f62290) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   44.44%   44.45%   +0.01%     
==========================================
  Files         164      164              
  Lines       16073    16055      -18     
==========================================
- Hits         7144     7138       -6     
+ Misses       8150     8142       -8     
+ Partials      779      775       -4     
Files Coverage Δ
x/move/types/params.go 69.33% <ø> (+6.96%) ⬆️

Copy link
Contributor

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 0b96174 into main Nov 29, 2023
7 checks passed
@beer-1 beer-1 deleted the fix/move-params branch November 29, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants