Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bcs args and add types #21

Merged
merged 5 commits into from
Nov 29, 2023
Merged

fix bcs args and add types #21

merged 5 commits into from
Nov 29, 2023

Conversation

ALPAC-4
Copy link
Contributor

@ALPAC-4 ALPAC-4 commented Nov 29, 2023

  • Fix

    • overwrite args
    • reusing serializer

  • Add

    • more types (object, option)

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

Merging #21 (ded9153) into main (593e738) will not change coverage.
The diff coverage is n/a.

❗ Current head ded9153 differs from pull request most recent head b125728. Consider uploading reports for the commit b125728 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   44.44%   44.44%           
=======================================
  Files         164      164           
  Lines       16073    16073           
=======================================
  Hits         7144     7144           
  Misses       8150     8150           
  Partials      779      779

@ALPAC-4 ALPAC-4 marked this pull request as ready for review November 29, 2023 11:59
@ALPAC-4 ALPAC-4 requested a review from a team as a code owner November 29, 2023 11:59
beer-1
beer-1 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ALPAC-4 ALPAC-4 merged commit ce1036d into main Nov 29, 2023
4 checks passed
@beer-1 beer-1 deleted the update/move-arg-types branch December 7, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beer-1 beer-1 beer-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ALPAC-4 @beer-1