Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: view function #23

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix: view function #23

merged 2 commits into from
Nov 30, 2023

Conversation

ALPAC-4
Copy link
Contributor

@ALPAC-4 ALPAC-4 commented Nov 30, 2023

Fix view function

@ALPAC-4 ALPAC-4 requested a review from a team as a code owner November 30, 2023 01:52
Vritra4
Vritra4 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@Vritra4 Vritra4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

beer-1
beer-1 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@beer-1 beer-1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but test seems failed

@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #23 (d47ae48) into main (ded9153) will increase coverage by 0.01%.
Report is 9 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   44.44%   44.45%   +0.01%     
==========================================
  Files         164      164              
  Lines       16073    16055      -18     
==========================================
- Hits         7144     7138       -6     
+ Misses       8150     8142       -8     
+ Partials      779      775       -4
Files Coverage Δ
x/move/types/params.go 69.33% <ø> (+6.96%) ⬆️

@beer-1 beer-1 merged commit c82131d into main Nov 30, 2023
7 checks passed
@beer-1 beer-1 deleted the fix/cli-move-view branch November 30, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beer-1 beer-1 beer-1 approved these changes

@Vritra4 Vritra4 Vritra4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ALPAC-4 @Vritra4 @beer-1