fix: return empty arrays when get 0 arguments #25

ALPAC-4 · 2023-12-04T05:38:23Z

Problem

return [''], [''] when give empty arguments

Solve

if arguments's length is 0 return [], []

codecov · 2023-12-04T05:47:15Z

Codecov Report

Merging #25 (778ed1d) into main (c82131d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   44.45%   44.45%           
=======================================
  Files         164      164           
  Lines       16055    16055           
=======================================
  Hits         7138     7138           
  Misses       8142     8142           
  Partials      775      775

beer-1

LGTM

fix: return empty arrays when get 0 arguments

778ed1d

ALPAC-4 requested a review from a team as a code owner December 4, 2023 05:38

beer-1 approved these changes Dec 5, 2023

View reviewed changes

beer-1 merged commit 4888e13 into main Dec 5, 2023
7 checks passed

beer-1 deleted the fix/empty-args branch December 5, 2023 02:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: return empty arrays when get 0 arguments #25

fix: return empty arrays when get 0 arguments #25

ALPAC-4 commented Dec 4, 2023

codecov bot commented Dec 4, 2023

beer-1 left a comment

fix: return empty arrays when get 0 arguments #25

fix: return empty arrays when get 0 arguments #25

Conversation

ALPAC-4 commented Dec 4, 2023

codecov bot commented Dec 4, 2023

Codecov Report

beer-1 left a comment

Choose a reason for hiding this comment