Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove map iterations #28

Merged
merged 1 commit into from
Dec 5, 2023
Merged

feat: remove map iterations #28

merged 1 commit into from
Dec 5, 2023

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Dec 5, 2023

go map iteration does not guarantee the ordering

@beer-1 beer-1 requested a review from a team as a code owner December 5, 2023 07:40
@beer-1 beer-1 self-assigned this Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #28 (628a96e) into main (c82131d) will increase coverage by 0.07%.
Report is 13 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   44.45%   44.53%   +0.07%     
==========================================
  Files         164      164              
  Lines       16055    16076      +21     
==========================================
+ Hits         7138     7159      +21     
  Misses       8142     8142              
  Partials      775      775              
Files Coverage Δ
x/distribution/keeper/allocation.go 89.62% <100.00%> (+0.48%) ⬆️
x/move/abci.go 71.69% <100.00%> (+1.10%) ⬆️
x/move/keeper/staking.go 64.04% <100.00%> (+1.67%) ⬆️

@beer-1 beer-1 merged commit c6252bb into main Dec 5, 2023
7 checks passed
@beer-1 beer-1 deleted the fix/avoid-map-iteration branch December 5, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant