Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing stargate query support #285

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Oct 14, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@beer-1 beer-1 requested a review from a team as a code owner October 14, 2024 06:49
Copy link

coderabbitai bot commented Oct 14, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request introduce new query routes to the keepers package in app/keepers/keepers.go, specifically enhancing the MoveKeeper configuration for the oracle module. Three new routes have been added: /connect.oracle.v2.Query/GetAllCurrencyPairs, /connect.oracle.v2.Query/GetPrice, and /connect.oracle.v2.Query/GetPrices. These modifications expand the functionality of the MoveKeeper without altering the existing structure or initialization processes.

Changes

File Path Change Summary
app/keepers/keepers.go Added new query routes to MoveKeeper: /connect.oracle.v2.Query/GetAllCurrencyPairs, /connect.oracle.v2.Query/GetPrice, /connect.oracle.v2.Query/GetPrices.

Possibly related PRs

Suggested reviewers

  • Vritra4

Poem

In the land of code where rabbits play,
New routes have hopped in, brightening the day.
Currency pairs and prices now flow,
With MoveKeeper ready, watch it grow!
So let’s celebrate this leap, oh so grand,
In the world of queries, we take a stand! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
app/keepers/keepers.go (1)

642-653: LGTM! Consider a minor improvement for consistency.

The addition of new query routes for the oracle module in the MoveKeeper configuration looks good. These routes (GetAllCurrencyPairs, GetPrice, and GetPrices) expand the functionality available to the Move VM, allowing it to interact with oracle data.

For improved consistency, consider grouping these new routes with other oracle-related configurations if they exist elsewhere in the file.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8414620 and 17b9365.

📒 Files selected for processing (1)
  • app/keepers/keepers.go (1 hunks)
🧰 Additional context used

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.61%. Comparing base (8414620) to head (17b9365).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   40.59%   40.61%   +0.02%     
==========================================
  Files         267      267              
  Lines       25400    25412      +12     
==========================================
+ Hits        10310    10322      +12     
  Misses      13503    13503              
  Partials     1587     1587              
Files with missing lines Coverage Δ
app/keepers/keepers.go 98.46% <100.00%> (+0.03%) ⬆️

@beer-1 beer-1 merged commit d7baefc into main Oct 16, 2024
11 checks passed
@beer-1 beer-1 deleted the feat/add-connect-stargate-query-support branch October 16, 2024 07:36
beer-1 added a commit that referenced this pull request Oct 23, 2024
beer-1 added a commit that referenced this pull request Oct 24, 2024
* support multisend

* bump movevm to v0.5.1

* add missing stargate query support (#285)

* fix nil memory access on authz (#281)

* fix: allow to be failed with invalid message without error (#283)

* allow to failed with invalid message

* set reason

* fix to consider movevm gas scale when we use infinity gas meter (#287)

* fix to use cache context at ibc hook (#288)

* feat: enable whitelist stableswap (#289)

* enable whitelist stableswap

* check division by zero and handle default values for balancer

* remove unnecessary slices.Copy

* ignore error

* fix test

* apply coderabbit comment

* emit same events with cosmos-sdk interface

* create account if not exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant