Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: directly emit move hook error #33

Merged
merged 2 commits into from
Dec 12, 2023
Merged

feat: directly emit move hook error #33

merged 2 commits into from
Dec 12, 2023

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Dec 12, 2023

ibc-go use cache context when calling OnRecvPacket so emitting the events are ignored. so we create error ack directly not using ibc-go one.

@beer-1 beer-1 self-assigned this Dec 12, 2023
@beer-1 beer-1 requested a review from a team as a code owner December 12, 2023 11:21
@beer-1 beer-1 merged commit 4f16b82 into main Dec 12, 2023
4 checks passed
@beer-1 beer-1 deleted the feat/directly-emit-move-hook-error branch December 12, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@beer-1 beer-1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beer-1