Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change fee checker logic #8

Merged
merged 1 commit into from
Nov 3, 2023
Merged

feat: change fee checker logic #8

merged 1 commit into from
Nov 3, 2023

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Nov 3, 2023

Sum the all fee coin values in base unit and compare with required base base.

@beer-1 beer-1 self-assigned this Nov 3, 2023
@beer-1 beer-1 requested a review from a team as a code owner November 3, 2023 06:59
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #8 (0f0a2d8) into main (3d35e9d) will increase coverage by 0.04%.
The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   46.88%   46.92%   +0.04%     
==========================================
  Files         148      148              
  Lines       14522    14547      +25     
==========================================
+ Hits         6808     6826      +18     
- Misses       6954     6958       +4     
- Partials      760      763       +3     
Files Coverage Δ
x/move/ante/fee.go 72.72% <59.09%> (-0.35%) ⬇️

Copy link
Contributor

@Vritra4 Vritra4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 4e75ba2 into main Nov 3, 2023
7 checks passed
@beer-1 beer-1 deleted the feat/sum-fee-amount branch November 3, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants