-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/challenger #14
Feat/challenger #14
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe changes involve a comprehensive restructuring of the codebase, including updates to import paths and modifications to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Bot
participant Challenger
participant Child
User->>Bot: Create NewBot
Bot->>Challenger: Initialize
Challenger->>Child: Create Child Instance
Child->>Challenger: Register Event Handlers
Challenger->>User: Start Processing
Note Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* change batch spec adding header bytes to batch data * bump opinit version * delete oracle option * bug fix marshal unmarshal batch data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firstly merge and I will do review later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firstly have checked challenger related updates
return nil | ||
} | ||
|
||
func (c *Challenger) Start(ctx context.Context) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At start, how about checking l1 and l2 provider height is bigger than the start height? It will prevent overwriting wrong state like last finalized deposit height and sequence.
deposit, output, oracle data and timeout check
Summary by CodeRabbit
New Features
Challenger
component for managing blockchain interactions, including deposit handling and challenge management.BotTypeChallenger
, enhancing bot functionality.README.md
for the Challenger, detailing its responsibilities.Bug Fixes
Documentation
Challenger
and its functionalities.Chores