Feat/batch #4
Merged
Feat/batch #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beer-1
approved these changes
Jul 30, 2024
| data, err := strconv.ParseInt(string(v), 10, 64) | ||
| if err != nil { | ||
| // must not happen | ||
| panic(err) |
There was a problem hiding this comment.
good to return error, but panic not bad in this case maybe.
| } | ||
| bs.PopBatchInfo() | ||
| } | ||
| // TODO: set da and key that match the current batch info |
There was a problem hiding this comment.
Suggested change
| // TODO: set da and key that match the current batch info | |
| // TODO: receive multiple DAs and use DA which is matched with the current batch info |
| return nil | ||
| } | ||
|
|
||
| func (h *Host) updateBatchInfoHandler(args nodetypes.EventHandlerArgs) error { |
|
|
||
| OutputSubmitterMnemonic: "", | ||
| BridgeExecutorMnemonic: "", | ||
| BatchSubmitterMnemonic: "", |
There was a problem hiding this comment.
Don't we need default configs for BatchConfig? and some validation too
| @@ -51,6 +53,7 @@ func NewExecutor(cfg *executortypes.Config, db types.DB, sv *server.Server, logg | |||
| db.WithPrefix([]byte(executortypes.ChildNodeName)), | |||
| logger.Named(executortypes.ChildNodeName), cdc, txConfig, | |||
| ), | |||
| batch: batch.NewBatchSubmitter(cfg.Version, cfg.DANodeConfig(), cfg.BatchConfig(), db.WithPrefix([]byte(executortypes.BatchNodeName)), logger.Named(executortypes.BatchNodeName), cdc, txConfig, homePath), | |||
|
|
|||
There was a problem hiding this comment.
seems we are receving da node config separately, but want to use host as our da node?
or should we run separate da node?
| @@ -72,8 +75,23 @@ func NewExecutor(cfg *executortypes.Config, db types.DB, sv *server.Server, logg | |||
| zap.Duration("submission_interval", bridgeInfo.BridgeConfig.SubmissionInterval), | |||
| ) | |||
|
|
|||
| executor.child.Initialize(executor.host, bridgeInfo) | |||
| err = executor.host.Initialize(executor.child, int64(bridgeInfo.BridgeId)) | |||
| da := executor.host | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.