Add systemd dependency on clickhouse-server #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felixoid
reviewed
Apr 16, 2024
Without this dependency, graphite-ch-optimizer will try to start before the Clickhouse server is ready, leading to a failure to start.
According to my research, this should not be a problem. Wants and After will happily ignore non-existing units. I also tried it on an existing server and the service started fine, even with the other unit not existing. |
Felixoid
approved these changes
Apr 16, 2024
|
Just in case, it makes sense to update the golang version too. 1.15 is a bit outdated |
|
@Felixoid good idea, a fresh build would not hurt anything 😉 |
Hipska
approved these changes
May 16, 2024
|
@lamaral are you here? =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this dependency, graphite-ch-optimizer will try to start before the Clickhouse server is ready, leading to a failure to start.