Skip instance_type selection if type is already set #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # 70 MB big json file in parallel for every VM. We are currently working | ||
| # on a different solution to prefill the instance_type for the disaster | ||
| # recovery case. We'll keep the functionality in igvm for now to be able | ||
| # to build VMs in AWS without the need of a prefill. |
There was a problem hiding this comment.
What is exactly the problem here? Is it loading the json file into Python structures or parsing those structures?
There was a problem hiding this comment.
The memory footprint of loading the file is too big. Building 10 machines in parallel that way, the server allocates more then 2GiB of memory and we want to be able to build at least 50 VMs in parallel on one server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current solution for figuring out the best instance_type is not scalable for the disaster recovery case because we are parsing a 70 MB big json file in parallel for every VM. We are currently working on a different solution to prefill the instance_type for the disaster recovery case. We'll keep the functionality in igvm for now to be able to build VMs in AWS without the need of a prefill.