Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use KMP to search Shorts Video ID #109

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from

Conversation

YT-Advanced
Copy link

@YT-Advanced YT-Advanced commented Dec 16, 2024

Need to test carefully before merging

@YT-Advanced YT-Advanced marked this pull request as ready for review December 17, 2024 05:48
@YT-Advanced
Copy link
Author

The delay when scrolling Shorts seem decreased

@inotia00
Copy link
Owner

When scrolling through Shorts, sometimes the video Id doesn't seem to update

@YT-Advanced
Copy link
Author

When scrolling through Shorts, sometimes the video Id doesn't seem to update

Uhm it is not reproduceable in my side.
Furthermore, YouTube prefetches the next Shorts, so in most use cases the videoId pattern is already built and should always be ready to use when litho is called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants