This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
forked from lesstif/php-jira-rest-client
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexP11223
force-pushed
the
feature/service-desk
branch
from
January 29, 2021 16:32
40a484f
to
9d35d60
Compare
AlexP11223
force-pushed
the
feature/service-desk
branch
from
February 1, 2021 15:51
56438ba
to
ea02907
Compare
AlexP11223
force-pushed
the
feature/service-desk
branch
from
February 1, 2021 17:14
ea02907
to
9ccb8ec
Compare
AlexP11223
force-pushed
the
feature/service-desk
branch
from
February 2, 2021 20:46
fdeb1fb
to
dd61c75
Compare
XedinUnknown
suggested changes
Mar 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, excellent work, and a superb addition to the original package!
src/ServiceDesk/Attachment/AttachmentCreationResultInterface.php
Outdated
Show resolved
Hide resolved
XedinUnknown
suggested changes
Mar 22, 2021
AlexP11223
force-pushed
the
feature/service-desk
branch
from
March 30, 2021 15:33
8adb069
to
28d54da
Compare
XedinUnknown
approved these changes
Apr 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Service Desk API needed for PROD-77.
I tried to keep this in similar style as the rest of the lib, while trying to do it better and more SOLID. So the API requests are grouped in
<API-Group>Service
classes inheritingJiraClient
like the rest of the lib. Most of the entities in this part have interfaces, which e.g. don't include setters needed only for JSON mapping.For paged queries there is Pagination similar to idealo SDK. It uses PhpStan/psalm
@template
generics for results. Sadly it is not supported in PhpStorm yet, so no autocompletion, etc.The tests are mostly e2e, so they require our test Jira. Can be run via
vendor/bin/phpunit tests/ServiceDesk
, connection config is in.env
and some config for tests (project id, ...) is in.env.phpunit
. Non-e2e tests (pagination, ...) are run by CI.Getting customer requests: not implemented because SD API cannot filter requests for the specified customer, need to use JQL from the standard API, already implemented.
Attachments: I implemented the attachment-related SD API, but looks like it is useless for our purposes because it does not allow to attach on behalf of another user, even if passing to
attachment
field when creating a request. 😂 The standard issue API seems to work.One problem with this lib is that it uses Curl directly instead of PSR-18. :( There was an issue about this, possibly with some work in progress.
And also it looks like there is no easy way in Curl to upload files from a stream without a real file in fs, except building the multipart stuff manually like here. So currently we would have to create tmp files for attachments.