Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Dialog Root - allow parent component to forward ref #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomislavhoracek
Copy link
Contributor

@tomislavhoracek tomislavhoracek commented Sep 4, 2024

This PR extends the Dialog Root component. Now we can pass ref to it.
No UI changes applied!

@tomislavhoracek tomislavhoracek force-pushed the chore/lw-10856-exdend-dialog-component branch from cd1e479 to 6ddb8e4 Compare September 4, 2024 16:37
Copy link

sonarcloud bot commented Sep 4, 2024

@tomislavhoracek tomislavhoracek self-assigned this Sep 4, 2024
@tomislavhoracek tomislavhoracek marked this pull request as ready for review September 4, 2024 16:39
@tomislavhoracek tomislavhoracek changed the title chore: allow parent component to forward ref chore: Dialog Root - allow parent component to forward ref Sep 4, 2024
@DominikGuzei
Copy link
Member

@tomislavhoracek it would be helpful to get some context/scenario about why this is needed/required? :)

@tomislavhoracek
Copy link
Contributor Author

@tomislavhoracek it would be helpful to get some context/scenario about why this is needed/required? :)

sure, thanks @DominikGuzei
So, for example, you open a dialog but you have to keep the app menu open since it shows the status of the action you choose in dialog. You have to control the state in such a specific case and say "Do not close the menu on outside click if you click on dialog". Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants