Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include root certs #62

Open
wants to merge 1 commit into
base: amir/deploy-all
Choose a base branch
from
Open

Include root certs #62

wants to merge 1 commit into from

Conversation

j-mueller
Copy link
Collaborator

We need the certificates in order to make requests to Blockfrost

@j-mueller j-mueller changed the base branch from main to amir/deploy-all January 9, 2025 16:01
@j-mueller j-mueller requested a review from choener January 9, 2025 16:01
@j-mueller
Copy link
Collaborator Author

@choener : I want the CA certificates to be added before the frontend code - do I need to reverse the list?

@j-mueller j-mueller marked this pull request as ready for review January 9, 2025 16:03
@j-mueller
Copy link
Collaborator Author

I tested this locally, curl localhost:8080/api/v1/query/global-params works now (previously failed with InternalException (HandshakeFailed (Error_Protocol "certificate has unknown CA" UnknownCa))

@j-mueller
Copy link
Collaborator Author

podman image tree Looks like it might be ok (assuming the root certificates are 502kb?)

image

choener
choener approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@choener choener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I checked the documentation regarding order of layers. Info is sparse, currently I strongly think we basically have a left fold.

@choener
Copy link
Collaborator

choener commented Jan 10, 2025

podman image tree Looks like it might be ok (assuming the root certificates are 502kb?)

image

Yes, that looks good:

tar tf 5ef35678ac332f865963693aefbdf6fe3222dfaf4c70c8b36f9d5015611d9679
tar: Removing leading `/' from member names
/
/etc
/etc/pki
/etc/pki/tls
/etc/pki/tls/certs
/etc/pki/tls/certs/ca-bundle.crt
/etc/ssl
/etc/ssl/certs
/etc/ssl/certs/ca-bundle.crt
/etc/ssl/certs/ca-certificates.crt
/nix
/nix/store
/nix/store/38j107590p1jp4l8v82vqcx5w5v0ip2z-nss-cacert-3.90
/nix/store/38j107590p1jp4l8v82vqcx5w5v0ip2z-nss-cacert-3.90/etc
/nix/store/38j107590p1jp4l8v82vqcx5w5v0ip2z-nss-cacert-3.90/etc/ssl
/nix/store/38j107590p1jp4l8v82vqcx5w5v0ip2z-nss-cacert-3.90/etc/ssl/certs
/nix/store/38j107590p1jp4l8v82vqcx5w5v0ip2z-nss-cacert-3.90/etc/ssl/certs/ca-bundle.crt
/nix/store/38j107590p1jp4l8v82vqcx5w5v0ip2z-nss-cacert-3.90/nix-support
/nix/store/38j107590p1jp4l8v82vqcx5w5v0ip2z-nss-cacert-3.90/nix-support/setup-hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choener choener choener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-mueller @choener