Determine tag *after* checkout #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choener
approved these changes
Jan 20, 2025
| @@ -29,6 +29,15 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
|
|
|||
| - name: Log in to ghcr.io | |||
There was a problem hiding this comment.
Moving the login to ghcr.io is technically not necessary, I think. But should be fine according to the readme. Had me tripped up why you moved that part, too.
(But to be sure: you wanted to move the login, too?)
There was a problem hiding this comment.
I moved it more or less accidentally but I agree that it shouldn't make a difference 😀
| registry: ${{ env.IMAGE_REGISTRY }} | ||
|
|
||
| - uses: actions/checkout@v4 | ||
|
|
There was a problem hiding this comment.
checkout then rev-parse seems fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git diff doesn't show this properly, but
When running the OCI workflow after a "push" action (for a new tag), we call
git rev-parseto figure out what the image tag should be. This only works afteractions/checkout. Before the checkout action there is no github repository andgit rev-parsefails.Sadly I only noticed this after having made an official release tag for v0.1.0. So now we'll have to go straight to v0.1.1.