Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for Lavalink v4 #18

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: Support for Lavalink v4 #18

wants to merge 10 commits into from

Conversation

Dolliwyx
Copy link
Member

@Dolliwyx Dolliwyx commented Aug 1, 2023

Description

This PR aims to add support for Lavalink v4, the new experimental version release. This release will also be replacing node-fetch in favor of undici.

This PR also allows support on CJS and ESM modules.

Motivation and Context

This change is essential to keep up with Lavalink's new versions. Moreover, the switch to undici is expected to yield better performance as it is written by the Node.js team itself.

How Has This Been Tested?

  • Set up a local Lavalink v4 environment.
  • Used in a Discord bot running Discord.js v14
  • Tested and validated proper integration with undici.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Dwigoric
Copy link
Member

The yarn lockfile has a merge conflict @Dolliwyx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants