Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuzzy matching: change request payload #4315

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fuzzy matching: change request payload #4315

merged 1 commit into from
Sep 25, 2023

Conversation

MJedr
Copy link
Contributor

@MJedr MJedr commented Sep 22, 2023

No description provided.

@MJedr MJedr force-pushed the improve-fuzzy-matching branch 2 times, most recently from 0997cfb to 2662504 Compare September 25, 2023 05:47
@drjova
Copy link
Contributor

drjova commented Sep 25, 2023

hmm shouldn't this be here https://github.com/inspirehep/inspirehep/blob/a8d0b8cce1ed78a0d744a7dac7738a5140548c08/backend/inspirehep/matcher/api.py#L292?

@MJedr
Copy link
Contributor Author

MJedr commented Sep 25, 2023

I think filtering here would be better cause we don't need to pass for example references in request to hep (they are not used by matcher)

@MJedr MJedr merged commit 1831786 into inspirehep:master Sep 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drjova drjova drjova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MJedr @drjova