This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
Bibmatch #366
Open
Bibmatch #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* previous version assumed proper logic of AND and OR * special mode for operator == 'OR' obsolete Signed-off-by: Kirsten Sachs <[email protected]>
* convert search string containing '/' to regular-expression search Signed-off-by: Kirsten Sachs <[email protected]>
* QRYSTR---@[operator] in config file can be used to set operator to AND or OR Signed-off-by: Kirsten Sachs <[email protected]>
|
Hi @ksachs I just came across this PR (I wasn't mentioned so I missed it, sorry!). Actually I believe you are the only user of bibmatch, and this fork of Invenio 1 we maintain in INSPIRE is not used by anyone else. So I guess we can merge this anyway and it won't harm :) |
|
The PR is mainly for your information. I fixed the local version at DESY which is running since a few month now. So you can call it fully tested ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not fully testet!!
Several stages of fixes to bibmatch_engine.py
The first commit is a bugfix. The original code assumes AND precedes OR.
Now braces are introduced to encapsulate sub-queries generated from several values of the same field.
E.g. (037__a:arXiv:1409.6313 OR 037__a:DESY-14-160)
The second commit is a by-pass to the known search bug for search-pattern with more than one '/'.
It (tries to) convert
(0247_a:10.1007/JHEP06(2015)049 OR 0247_a:10.3204/PUBDB-2015-02435)
to
(0247_a:/^10.1007.JHEP06.2015.049$/ OR 0247_a:/^10.3204.PUBDB-2015-02435$/)
The third commit is a feature we need at DESY.
I.e. switch the operator from OR to AND while processing the querystrings from a config file.
DOIs and report-numbers have to be combined by OR,
authors have to be combined by AND.
Up to you what you think is useful for the rest of the world.