Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ReconcileRequeue limitation #574

Closed
wants to merge 4 commits into from
Closed

[WIP] ReconcileRequeue limitation #574

wants to merge 4 commits into from

Conversation

worryg0d
Copy link
Collaborator

@worryg0d worryg0d commented Sep 21, 2023

Reconcile Requeue limitation #559

Implemented ReconcileRequeue limiter which limits the amount of reconciles for each resource controlled by its namespacedName.

The limiter was implemented as a wrapper on the reconcile.Reconciler interface.

Usage

The limiter can be used in the SetupWithManager func as shown in the Cassandra example.

If the reconcile.result == models.ReconcileRequeue the limiter increments amount of reconciles for the resource.

If the result is models.ExitReconcile the limiter resets the counter.

Also if the amount of ReconcileRequeues reaches the MaxReconcileRequeueRetries limiter, it finishes the current reconcile with the models.ExtiReconcile result and resets the counter for the resource.

Also, I added a useful script dev-build to Makefile which avoids pushing docker-images to the DockerHub by loading them to Kind directly.

@worryg0d worryg0d added the enhancement New feature or request label Sep 21, 2023
@worryg0d worryg0d requested a review from ribaraka September 21, 2023 11:31
@worryg0d worryg0d self-assigned this Sep 21, 2023
@worryg0d worryg0d marked this pull request as draft September 21, 2023 11:31
@worryg0d worryg0d marked this pull request as ready for review September 22, 2023 08:02
@worryg0d
Copy link
Collaborator Author

Closed because the framework allows to define own custom limiters which are more flexible. It was implemented in PR #579

@worryg0d worryg0d closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant