Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconcile Requeue limitation #559
Implemented ReconcileRequeue limiter which limits the amount of reconciles for each resource controlled by its
namespacedName
.The limiter was implemented as a wrapper on the
reconcile.Reconciler
interface.Usage
The limiter can be used in the
SetupWithManager
func as shown in the Cassandra example.If the
reconcile.result == models.ReconcileRequeue
the limiter increments amount of reconciles for the resource.If the result is
models.ExitReconcile
the limiter resets the counter.Also if the amount of ReconcileRequeues reaches the
MaxReconcileRequeueRetries
limiter, it finishes the current reconcile with themodels.ExtiReconcile
result and resets the counter for the resource.Also, I added a useful script
dev-build
to Makefile which avoids pushing docker-images to the DockerHub by loading them to Kind directly.