Check for no external IPs or private cluster in PostgreSQL webhook is implemented #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoodgeMatvey
requested review from
RostislavPorohnya,
ribaraka,
testisnullus,
tengu-alt,
OleksiienkoMykyta and
worryg0d
worryg0d
approved these changes
Oct 6, 2023
ribaraka
requested changes
Oct 6, 2023
Comment on lines
+202
to
+225
| nodeList := &k8sCore.NodeList{} | ||
|
|
||
| err := pgv.K8sClient.List(ctx, nodeList, &client.ListOptions{}) | ||
| if err != nil { | ||
| return fmt.Errorf("cannot list node list, error: %v", err) | ||
| } | ||
|
|
||
| var externalIPExists bool | ||
| for _, node := range nodeList.Items { | ||
| for _, nodeAddress := range node.Status.Addresses { | ||
| if nodeAddress.Type == k8sCore.NodeExternalIP { | ||
| externalIPExists = true | ||
| break | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if !externalIPExists || pg.Spec.PrivateNetworkCluster { | ||
| return fmt.Errorf("cannot create PostgreSQL user, if your cluster is private or has no external ips " + | ||
| "you need to configure peering and remove user references from cluster specification") | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
please, remove a similar code from the controller
DoodgeMatvey
force-pushed
the
issue-588-externalip-webhook
branch
from
4c337f0 to
2f45543
Compare
… webhook is implemented
testisnullus
approved these changes
Oct 6, 2023
ribaraka
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #588