Issue-599, Handle of deleting default secret for KafkaConnect and Zookeeper resources #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worryg0d
requested review from
ribaraka,
testisnullus,
tengu-alt and
OleksiienkoMykyta
ribaraka
approved these changes
Oct 23, 2023
tengu-alt
approved these changes
Oct 23, 2023
OleksiienkoMykyta
approved these changes
Oct 24, 2023
testisnullus
approved these changes
Oct 25, 2023
Comment on lines
231
to
247
| func (r *ZookeeperReconciler) deleteDefaultSecret(ctx context.Context, zk *v1beta1.Zookeeper) error { | ||
| secret := &v1.Secret{} | ||
| err := r.Get(ctx, types.NamespacedName{ | ||
| Name: fmt.Sprintf(models.DefaultUserSecretNameTemplate, models.DefaultUserSecretPrefix, zk.Name), | ||
| Namespace: zk.Namespace, | ||
| }, secret) | ||
|
|
||
| if err != nil { | ||
| if k8serrors.IsNotFound(err) { | ||
| return nil | ||
| } | ||
|
|
||
| return err | ||
| } | ||
|
|
||
| return r.Delete(ctx, secret) | ||
| } |
There was a problem hiding this comment.
Can we implement this method as a function in helpers?
There was a problem hiding this comment.
Maybe it makes sense because there are two the same methods but for different resources. I'll look for a solution
There was a problem hiding this comment.
Created deleteDefaultUserSecret function in helpers
…ect resources was implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our previous implementation when Zookeeper or KafkaConnect resource is deleted it keeps secret with its default user credentials in k8s. It causes problems when we create KafkaConnect cluster, delete it, and create it again.
Now controllers delete the secrets of the resources during deletion operation.
ref #599