Issue-598, Handling of bundled use only resources updation #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worryg0d
requested review from
DoodgeMatvey,
RostislavPorohnya,
ribaraka,
testisnullus,
tengu-alt and
OleksiienkoMykyta
worryg0d
changed the title
tengu-alt
reviewed
Oct 25, 2023
| @@ -65,4 +67,6 @@ var ( | |||
| ErrExposeServiceNotCreatedYet = errors.New("expose service is not created yet") | |||
| ErrExposeServiceEndpointsNotCreatedYet = errors.New("expose service endpoints is not created yet") | |||
| ErrOnlySingleConcurrentResizeAvailable = errors.New("only single concurrent resize is allowed") | |||
|
|
|||
| ErrBundledUseOnlyResourceUpdateIsNotSupported = errors.New("updating of bundled use resource is not supported") | |||
There was a problem hiding this comment.
I guess this new line is unnecessary, let's remove it. What are the other teammates opinions?
testisnullus
approved these changes
Oct 25, 2023
OleksiienkoMykyta
approved these changes
Oct 26, 2023
ribaraka
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use Instaclustr Console to create a cadence cluster with packaged solutions of Cassandra, Kafka, or OpenSearch it creates clusters that are only for bundled use. It means that a customer can't update bundled resource specifications in any way.
The operator does the same, but it doesn't create resources for bundled use only. So a customer can update those resource specifications.
This PR aims to fix the problem of packaged provisioning for Cadecene.
closes #598