generic on-premises cluster provisioning #618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testisnullus
requested changes
Nov 13, 2023
Comment on lines
73
to
82
| type OnPremisesSpec struct { | ||
| StorageClassName string `json:"storageClassName"` | ||
| OSDiskSize string `json:"osDiskSize"` | ||
| DataDiskSize string `json:"dataDiskSize"` | ||
| SSHGatewayCPU int64 `json:"sshGatewayCPU,omitempty"` | ||
| SSHGatewayMemory string `json:"sshGatewayMemory,omitempty"` | ||
| NodeCPU int64 `json:"nodeCPU"` | ||
| NodeMemory string `json:"nodeMemory"` | ||
| OSImageURL string `json:"osImageURL"` | ||
| CloudInitScriptRef *NamespacedName `json:"cloudInitScriptRef"` |
There was a problem hiding this comment.
Let's move to the cluster's models
controllers/clusters/on_premise.go
Outdated
| ClusterID string | ||
| CdcID string | ||
| OnPremisesSpec *v1beta1.OnPremisesSpec | ||
| ExposeNodePorts []k8scorev1.ServicePort |
There was a problem hiding this comment.
ExposeNodePorts -> ExposePorts or PortsToExpose, let's rename because the ExposeNodePorts name creates wrong connotations with k8s NodePort service
There was a problem hiding this comment.
renamed to ExposePorts
testisnullus
requested changes
Nov 14, 2023
| Labels: map[string]string{ | ||
| models.ClusterIDLabel: bootstrap.ClusterID, | ||
| }, | ||
| //Finalizers: []string{models.DeletionFinalizer}, |
There was a problem hiding this comment.
Remove this comment please if unused
testisnullus
approved these changes
Nov 14, 2023
taaraora
requested changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.