Redis replicationFactor/replicaNodes immutable #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worryg0d
requested review from
ribaraka,
testisnullus,
tengu-alt and
OleksiienkoMykyta
Comment on lines
68
to
75
| if dataCentre.ReplicationFactor > 0 && dataCentre.NodesNumber == 0 { | ||
| dataCentre.NodesNumber = dataCentre.MasterNodes * dataCentre.ReplicationFactor | ||
| } else if dataCentre.NodesNumber > 0 && dataCentre.ReplicationFactor == 0 { | ||
| dataCentre.ReplicationFactor = dataCentre.NodesNumber / dataCentre.MasterNodes | ||
| } | ||
| } |
There was a problem hiding this comment.
If the replication factor and nodes number are equal to 0, I assume that we create master nodes only, am I right?
tengu-alt
approved these changes
Jan 16, 2024
ribaraka
requested changes
Jan 17, 2024
Comment on lines
68
to
69
| fmt.Println("DEFAULTER") | ||
| fmt.Println("nodes number", dataCentre.NodesNumber) |
| @@ -869,9 +869,22 @@ func (r *RedisReconciler) newWatchStatusJob(redis *v1beta1.Redis) scheduler.Job | |||
| } | |||
| } | |||
|
|
|||
| if iRedis.Status.CurrentClusterOperationStatus == models.NoOperation && | |||
| equals := redis.Spec.IsEqual(iRedis.Spec) | |||
There was a problem hiding this comment.
please add this logic to the rest Kinds
worryg0d
force-pushed
the
issue-676
branch
2 times, most recently
from
99a3b4e to
f270654
Compare
…for redis resource
ribaraka
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides immutability for the
replicationFactorandreplicaNodesfields of the Redis data centre.Also, it provides automatical reconcile of external changes of the k8s resource spec equals to instaclustr resource spec.
closes #676