Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafkamanagement general validation was covered with tests #716

Merged
merged 1 commit into from
Feb 19, 2024
Merged

kafkamanagement general validation was covered with tests #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions apis/kafkamanagement/v1beta1/validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ func (kacl *KafkaACL) validateUpdate(oldKafkaACL *KafkaACL) error {
if kacl.Spec.UserQuery != oldKafkaACL.Spec.UserQuery {
return fmt.Errorf("userQuery field is immutable")
}
if strings.HasPrefix(kacl.Spec.UserQuery, models.ACLUserPrefix) {
return fmt.Errorf("user query should not have %s prefix", models.ACLUserPrefix)
}

for _, acl := range kacl.Spec.ACLs {
if strings.TrimPrefix(acl.Principal, models.ACLUserPrefix) != kacl.Spec.UserQuery {
Expand Down
377 changes: 377 additions & 0 deletions apis/kafkamanagement/v1beta1/validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,377 @@
package v1beta1

import (
"testing"

v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

func TestKafkaACL_validateCreate(t *testing.T) {
type fields struct {
TypeMeta v1.TypeMeta
ObjectMeta v1.ObjectMeta
Spec KafkaACLSpec
Status KafkaACLStatus
}
tests := []struct {
name string
fields fields
wantErr bool
}{
{
name: "empty acls field",
fields: fields{
Spec: KafkaACLSpec{
ACLs: nil,
},
},
wantErr: true,
},
{
name: "invalid principal",
fields: fields{
Spec: KafkaACLSpec{
ACLs: []ACL{{
Principal: "invalid",
}},
},
},
wantErr: true,
},
{
name: "invalid prefix in user query",
fields: fields{
Spec: KafkaACLSpec{
ACLs: []ACL{{
Principal: "User:test",
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
}},
UserQuery: "User:test",
},
},
wantErr: true,
},
{
name: "valid spec",
fields: fields{
Spec: KafkaACLSpec{
ACLs: []ACL{{
Principal: "User:test",
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
}},
UserQuery: "test",
},
},
wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
kacl := &KafkaACL{
TypeMeta: tt.fields.TypeMeta,
ObjectMeta: tt.fields.ObjectMeta,
Spec: tt.fields.Spec,
Status: tt.fields.Status,
}
if err := kacl.validateCreate(); (err != nil) != tt.wantErr {
t.Errorf("validateCreate() error = %v, wantErr %v", err, tt.wantErr)
}
})
}
}

func Test_validate(t *testing.T) {
type args struct {
acl ACL
}
tests := []struct {
name string
args args
wantErr bool
}{
{
name: "invalid PermissionType",
args: args{
acl: ACL{
PermissionType: "test",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
},
},
wantErr: true,
},
{
name: "valid PermissionType",
args: args{
acl: ACL{
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
},
},
wantErr: false,
},
{
name: "invalid PatternType",
args: args{
acl: ACL{
PermissionType: "DENY",
PatternType: "test",
Operation: "ALL",
ResourceType: "CLUSTER",
},
},
wantErr: true,
},
{
name: "valid PatternType",
args: args{
acl: ACL{
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
},
},
wantErr: false,
},
{
name: "invalid Operation",
args: args{
acl: ACL{
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "test",
ResourceType: "CLUSTER",
},
},
wantErr: true,
},
{
name: "valid Operation",
args: args{
acl: ACL{
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
},
},
wantErr: false,
},
{
name: "invalid ResourceType",
args: args{
acl: ACL{
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "test",
},
},
wantErr: true,
},
{
name: "valid ResourceType",
args: args{
acl: ACL{
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
},
},
wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if err := validate(tt.args.acl); (err != nil) != tt.wantErr {
t.Errorf("validate() error = %v, wantErr %v", err, tt.wantErr)
}
})
}
}

func TestKafkaACL_validateUpdate(t *testing.T) {
type fields struct {
TypeMeta v1.TypeMeta
ObjectMeta v1.ObjectMeta
Spec KafkaACLSpec
Status KafkaACLStatus
}
type args struct {
oldKafkaACL *KafkaACL
}
tests := []struct {
name string
fields fields
args args
wantErr bool
}{
{
name: "empty acls",
fields: fields{
Spec: KafkaACLSpec{
ACLs: nil,
},
},
wantErr: true,
},
{
name: "change clusterID",
fields: fields{
Spec: KafkaACLSpec{
ACLs: []ACL{{
Principal: "User:test",
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
}},
ClusterID: "new",
},
},
args: args{
oldKafkaACL: &KafkaACL{
Spec: KafkaACLSpec{
ACLs: []ACL{{
Principal: "User:test",
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
}},
ClusterID: "test",
},
},
},
wantErr: true,
},
{
name: "change userQuery",
fields: fields{
Spec: KafkaACLSpec{
ACLs: []ACL{{
Principal: "User:test",
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
}},
ClusterID: "test",
UserQuery: "new",
},
},
args: args{
oldKafkaACL: &KafkaACL{
Spec: KafkaACLSpec{
ACLs: []ACL{{
Principal: "User:test",
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
}},
ClusterID: "test",
UserQuery: "test",
},
},
},
wantErr: true,
},
{
name: "different principal and userQuery",
fields: fields{
Spec: KafkaACLSpec{
ACLs: []ACL{{
Principal: "User:test",
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
}},
ClusterID: "test",
UserQuery: "diff",
},
},
args: args{
oldKafkaACL: &KafkaACL{
Spec: KafkaACLSpec{
ACLs: []ACL{{
Principal: "User:test",
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
}},
ClusterID: "test",
UserQuery: "diff",
},
},
},
wantErr: true,
},
{
name: "valid update",
fields: fields{
Spec: KafkaACLSpec{
ACLs: []ACL{{
Principal: "User:test",
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
},
{
Principal: "User:test",
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
},
},
ClusterID: "test",
UserQuery: "test",
},
},
args: args{
oldKafkaACL: &KafkaACL{
Spec: KafkaACLSpec{
ACLs: []ACL{{
Principal: "User:test",
PermissionType: "DENY",
PatternType: "LITERAL",
Operation: "ALL",
ResourceType: "CLUSTER",
}},
ClusterID: "test",
UserQuery: "test",
},
},
},
wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
kacl := &KafkaACL{
TypeMeta: tt.fields.TypeMeta,
ObjectMeta: tt.fields.ObjectMeta,
Spec: tt.fields.Spec,
Status: tt.fields.Status,
}
if err := kacl.validateUpdate(tt.args.oldKafkaACL); (err != nil) != tt.wantErr {
t.Errorf("validateUpdate() error = %v, wantErr %v", err, tt.wantErr)
}
})
}
}
Loading