Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adapt to logger's incoming stacklevel #661

Closed
wants to merge 1 commit into from

Conversation

GSVarsha
Copy link
Contributor

Related to #652

Bypass the stack level of our instrumentation when the keyword stacklevel is set as well.

More details on #660.

@GSVarsha GSVarsha added bug Review & Merge legacy_2.x Issues and PRs related to the legacy 2.x series. labels Oct 28, 2024
@GSVarsha GSVarsha added this to the H2-2024 milestone Oct 28, 2024
@GSVarsha GSVarsha self-assigned this Oct 28, 2024
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary to backport your solution for the legacy branch @GSVarsha.
The customer has already tested the previous patch and it runs with no issues.
Thanks anyway.

@GSVarsha
Copy link
Contributor Author

It is not necessary to backport your solution for the legacy branch @GSVarsha. The customer has already tested the previous patch and it runs with no issues. Thanks anyway.

I will close this issue then :)

@GSVarsha GSVarsha closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug legacy_2.x Issues and PRs related to the legacy 2.x series. Review & Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants