Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API implementation for Infra Alert Config #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

parekh-raj
Copy link

We want to add support for Infrastructure Smart Alerts.

This PR adds API implementation for Infra Alert Config.
In a follow-up PR, I'll add resource changes with the required TF schema.

@parekh-raj parekh-raj added enhancement New feature or request good first issue Good for newcomers labels Oct 23, 2024
@parekh-raj parekh-raj self-assigned this Oct 23, 2024
Comment on lines +107 to +109
func (api *baseInstanaAPI) InfraAlertConfig() RestResource[*InfraAlertConfig] {
return NewCreatePOSTUpdatePOSTRestResource(InfraAlertConfigResourcePath, NewCustomPayloadFieldsUnmarshallerAdapter(NewDefaultJSONUnmarshaller(&InfraAlertConfig{})), api.client)
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be used in my follow-up PR.

Comment on lines +51 to +52
PerSecondAggregation = Aggregation("PER_SECOND")
IncreaseAggregation = Aggregation("INCREASE")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added these two as it was missing.

@rorywelch
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants